Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messaging.kafka.message.offset attribute #2982

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Add messaging.kafka.message.offset attribute #2982

merged 4 commits into from
Dec 1, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Fixes #2971

Changes

Introduces a new messaging.kafka.message.offset attribute that is supposed to store the offset of a Kafka message. I used the naming pattern introduced in #2957, assuming it's probably going to land in the same release as this change.

@mateuszrzeszutek mateuszrzeszutek requested review from a team November 23, 2022 09:31
pyohannes
pyohannes approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed in the messaging workgroup (see summary in the related issue).

Having a dedicated offset attribute is preferred to using the offset as message id.

@arminru arminru added area:semantic-conventions Related to semantic conventions semconv:messaging spec:trace Related to the specification/trace directory labels Nov 25, 2022
@breedx-splk breedx-splk mentioned this pull request Nov 28, 2022
Open
carlosalberto
carlosalberto reviewed Nov 29, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@carlosalberto carlosalberto merged commit f2cd19a into open-telemetry:main Dec 1, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the kafka-offset branch December 5, 2022 16:07
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Add messaging.kafka.message.offset attribute (open-telemetry#2982)
3d0a8bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@breedx-splk breedx-splk breedx-splk approved these changes

@pyohannes pyohannes pyohannes approved these changes

@arminru arminru arminru approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:semantic-conventions Related to semantic conventions semconv:messaging spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Kafka offset be used as messaging.message.id?
6 participants
@mateuszrzeszutek @carlosalberto @joaopgrassi @arminru @pyohannes @breedx-splk